Patch Set 1: Code-Review-1

Thanks for doing this. There are a lot more instances of this, though... I see at least 212 instances using `grep -rH '\/\/[[:space:]]' *.c *.h | wc -l`.

Want to try and fix some more instances while you're at it? Also, maybe we can look into git hooks to prevent more C++ style comments from creeping in?


I don't mind committing this as an incremental step, though. (marking as -1 just so I see it as reviewed in the gerrit dashboard)

Currently, this change is preventing other changes in the train from being submitted. I don't think I will be able to fix more instances soon (two busy weeks ahead), so I would prefer to do this incrementally.

Patch Set 1:

The coding style allows C++ style comments. It was explicitly added, and diverted from the original Linux kernel coding style. I prefer, that it should be consistent in files though.

Ack. In the files I touched, I replaced every single C++ style comment with a C style comment, so they are consistent.

View Change

To view, visit change 38660. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I74102108ef4b0365a9bf0fea20f012aece201892
Gerrit-Change-Number: 38660
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Sun, 02 Feb 2020 13:05:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment