The original author's PR was titled "Added W25P16 (tested) and ZD25D40 (untested)"
However W25P16 support wasn't really added - There seemed to be some confusion about what the author was intending to add support for.
The ZD25D40 part looked good so I split that out. I also added ZD25D20 support in the follow-up in my own patch.
View Change
To view, visit change 23701. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0400b059ddacdf166d1b77f619becec3a250cece
Gerrit-Change-Number: 23701
Gerrit-PatchSet: 2
Gerrit-Owner: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Mon, 12 Feb 2018 02:49:27 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No