David Hendricks posted comments on this change.

View Change

Patch set 1:Code-Review -1

Just a little bikeshedding, otherwise LGTM.

(1 comment)

• File spi25.c:

  • Patch Set #1, Line 326: spi_simple_write_cmd

    Is there anything other than chip erase commands that this applies to? I think this should be called "spi_erase_cmd" or something more specific to its purpose since it doesn't handle data or addresses.

To view, visit change 22018. To unsubscribe, visit settings.