Nikolai Artemiev has uploaded this change for review.
flashchips.c: remove WREN from GD25Q256D enter 4BA sequence
As noted in a comment on CB:35480, the GD25Q256D datasheet indicates
that the chip does not requre a WREN command to enter 4BA mode.
Testing has confirmed that a WREN command is not requried, so change the
flashchip feature flags from FEATURE_4BA_WREN to FEATURE_4BA.
Coreboot issue: https://ticket.coreboot.org/issues/356
BUG=none
BRANCH=none
TEST=read/write/erase/verify GD25Q256D flash with FT2232H programmer
Change-Id: I96e48933f33c52c0d10a0d4cb7f7e07c1fceab99
Signed-off-by: Nikolai Artemiev <nartemiev@google.com>
---
M flashchips.c
1 file changed, 23 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/42/70342/1
diff --git a/flashchips.c b/flashchips.c
index 6f65389..7ea8601 100644
--- a/flashchips.c
+++ b/flashchips.c
@@ -6849,7 +6849,7 @@
.model_id = GIGADEVICE_GD25Q256D,
.total_size = 32768,
.page_size = 256,
- .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_4BA_WREN |
+ .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_4BA |
FEATURE_WRSR_EXT2 | FEATURE_WRSR2 | FEATURE_WRSR3,
.tested = TEST_OK_PREWB,
.probe = PROBE_SPI_RDID,
To view, visit change 70342. To unsubscribe, or for help writing mail filters, visit settings.