Attention is currently required from: Felix Singer, Angel Pons, Anastasia Klimchuk, Steve Markgraf.
View Change
1 comment:
Patchset:
Patch Set #6:
Hi, Great work.
I have two suggestions:
- Can you rename this driver to `linux_gpio_spi`, this would make it clear which protocol is used.
- Can you convert the `gpiochip=X` parameter to `dev=/dev/gpiochipX` to be aligned with linux_spi or linux_mtd
To view, visit change 71801. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Icad3eb7764f28feaea51bda3a7893da724c86d06
Gerrit-Change-Number: 71801
Gerrit-PatchSet: 6
Gerrit-Owner: Steve Markgraf <steve@steve-m.de>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger@posteo.net>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Attention: Steve Markgraf <steve@steve-m.de>
Gerrit-Comment-Date: Mon, 23 Jan 2023 14:02:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment