Attention is currently required from: Simon Buhrow, Thomas Heijligen, Aarya.

View Change

1 comment:

• File spi.c:

  • Patch Set #2, Line 50: &spi_erase_at45cs_sector, 0x50},

    Nico, please have a look here at45db.c:417 spi_erase_at45cs_sector(). […]

    That is quite annoying. The logical thing to do would be to return both
    at once, and then call probe_opcode() for each of them. Either as array
    (0-terminated would be easiest) or multiple opcodes encoded into one
    integer, e.g.

        {&spi_erase_at45cs_sector, 0x7c << 8 | 0x50},

    What makes it even more annoying is that we would have to adapt the
    spi_get_erasefn_from_opcode() function too, if it should keep using
    the same list (even though we know it won't be called for AT45 chips).

    Not sure what is the best way to go forward.

To view, visit change 67354. To unsubscribe, or for help writing mail filters, visit settings.