Nico Huber submitted this change.

View Change

layout: Drop `count` parameter of flashrom_layout_new()

Change-Id: I22c180c9971068b1ae101845ce88484c6842b852
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/33544
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Anastasia Klimchuk <aklm@chromium.org>
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
M flashrom.c
M ich_descriptors.c
M layout.c
M libflashrom.h
4 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/flashrom.c b/flashrom.c
index 34cbdac..b20e3e1 100644
--- a/flashrom.c
+++ b/flashrom.c
@@ -823,7 +823,7 @@
 		return -1;
 
 	/* Fill default layout covering the whole chip. */
-	if (flashrom_layout_new(&flash->default_layout, 1) ||
+	if (flashrom_layout_new(&flash->default_layout) ||
 	    flashrom_layout_add_region(flash->default_layout,
 			0, flash->chip->total_size * 1024 - 1, "complete flash") ||
 	    flashrom_layout_include_region(flash->default_layout, "complete flash"))
diff --git a/ich_descriptors.c b/ich_descriptors.c
index 5e6c7fb..21fc40b 100644
--- a/ich_descriptors.c
+++ b/ich_descriptors.c
@@ -1279,7 +1279,7 @@
 		return 1;
 	}
 
-	if (flashrom_layout_new(layout, ARRAY_SIZE(regions)))
+	if (flashrom_layout_new(layout))
 		return 2;
 
 	ssize_t i;
diff --git a/layout.c b/layout.c
index 8047a93..e71f6a4 100644
--- a/layout.c
+++ b/layout.c
@@ -34,7 +34,7 @@
 struct flashrom_layout *get_global_layout(void)
 {
 	if (!global_layout)
-		flashrom_layout_new(&global_layout, 0);
+		flashrom_layout_new(&global_layout);
 	return global_layout;
 }
 
@@ -378,12 +378,11 @@
  * @brief Create a new, empty layout.
  *
  * @param layout Pointer to returned layout reference.
- * @param count  Number of layout entries to allocate.
  *
  * @return 0 on success,
  *         1 if out of memory.
  */
-int flashrom_layout_new(struct flashrom_layout **const layout, const unsigned int count)
+int flashrom_layout_new(struct flashrom_layout **const layout)
 {
 	*layout = malloc(sizeof(**layout));
 	if (!*layout) {
diff --git a/libflashrom.h b/libflashrom.h
index b13b3fb..3bd6855 100644
--- a/libflashrom.h
+++ b/libflashrom.h
@@ -106,7 +106,7 @@
 int flashrom_image_verify(struct flashrom_flashctx *, const void *buffer, size_t buffer_len);
 
 struct flashrom_layout;
-int flashrom_layout_new(struct flashrom_layout **, unsigned int count);
+int flashrom_layout_new(struct flashrom_layout **);
 int flashrom_layout_read_from_ifd(struct flashrom_layout **, struct flashrom_flashctx *, const void *dump, size_t len);
 int flashrom_layout_read_fmap_from_rom(struct flashrom_layout **,
 		struct flashrom_flashctx *, off_t offset, size_t length);

To view, visit change 33544. To unsubscribe, or for help writing mail filters, visit settings.