Attention is currently required from: Edward O'Callaghan, Angel Pons, Daniel Campello, Anastasia Klimchuk.

View Change

2 comments:

• File layout.c:

  • Patch Set #8, Line 388: *layout = malloc(sizeof(**layout));

    Given that you memset() the allocated space afterwards, use calloc() instead?

    I like to see it explicitly if something is cleared explicitly. I can try
    something else, though. Maybe you'll like it better.

  • Patch Set #8, Line 458:

    if (layout == global_layout)
    		return;
    
    	while (layout && layout->head) {
    		struct romentry *const entry = layout->head;
    		layout->head = entry->next;
    		free(entry->file);
    		free(entry->name);
    		free(entry);
    	}
    	free(layout);
    

    Given that `layout` is not modified in the while loop, how about evaluating it once? […]

    Ack. Might make it less odd to read.

To view, visit change 33521. To unsubscribe, or for help writing mail filters, visit settings.