Nico Huber posted comments on this change.

View Change

Patch set 3:Code-Review -1

The patch is fine, but doesn't solve the real problem:
spi_get_valid_read_addr() shouldn't exist. We are testing
something programmer specific right before giving control
to the programmer driver... ichspi should just test this.

To view, visit change 19418. To unsubscribe, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-MessageType: comment
Gerrit-Change-Id: Icbac513c5339e8aff624870252133284ef85ab73
Gerrit-Change-Number: 19418
Gerrit-PatchSet: 3
Gerrit-Owner: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Mon, 16 Oct 2017 17:03:14 +0000
Gerrit-HasComments: No