Attention is currently required from: Chen, Alexander Goncharov.
Patch set 2:Code-Review +1
View Change
2 comments:
Commit Message:
Patch Set #2, Line 7: spi
Sorry I didn't notice in the first pass: this should be `jlink_spi` , so that it describes more specifically where the change is.
Just change `spi` -> `jlink_spi`
Patchset:
Patch Set #2:
One more thing I forgot on the first pass: could you please update the manpage, it is here:
doc/classic_cli_manpage.rst
It currently still mentions two possible values for `cs` option.
Thank you!
To view, visit change 75011. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I0cb467fcc2c403a25f260462de0cd020e7022bb1
Gerrit-Change-Number: 75011
Gerrit-PatchSet: 2
Gerrit-Owner: Chen <c@jia.je>
Gerrit-Reviewer: Alexander Goncharov <chat@joursoir.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Chen <c@jia.je>
Gerrit-Attention: Alexander Goncharov <chat@joursoir.net>
Gerrit-Comment-Date: Wed, 10 May 2023 02:15:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment