Attention is currently required from: Nico Huber, Angel Pons, Nikolai Artemiev.
View Change
2 comments:
File dummyflasher.c:
Patch Set #16, Line 339: data->emu_status[0] &= ro_bits;
And what does that tell us about the state of WIP after that line? […]
Mixed two comments. CB:60224 should be mentioned here.
Patch Set #16, Line 347: other chips might differ
OK, see CB:60224.
Updated comment.
To view, visit change 59072. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I177ae3f068f03380f5b3941d9996a07205672e59
Gerrit-Change-Number: 59072
Gerrit-PatchSet: 19
Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Maciej Pijanowski <maciej.pijanowski@3mdeb.com>
Gerrit-CC: Nikolai Artemiev <nartemiev@google.com>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Comment-Date: Sun, 19 Dec 2021 14:42:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Comment-In-Reply-To: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Gerrit-MessageType: comment