Attention is currently required from: Sam McNally, Nico Huber, Nicola Corna, Paul Menzel, Stefan Reinauer, David Hendricks, Edward O'Callaghan, Arthur Heymans, Carl-Daniel Hailfinger.

View Change

2 comments:

• File cli_classic.c:

  • Patch Set #25, Line 140:

    static char *get_optional_filename(char *argv[])
    {
    	char *filename = NULL;
    
    	if (optarg == NULL && argv[optind] != NULL && argv[optind][0] != '-')
    		filename = strdup(argv[optind++]);
    	else if (optarg != NULL)
    		filename = strdup(optarg);
    
    	return filename;
    }
    

    Not a overtly strong feeling here however should this part of the story perhaps be a separate patch? […]

    This takes care of the "optional" nature of the -r/-w/-v options. We could separate on another patch by removing the `if (filename)` of read_by_layout, do_write and do_verify. Not sure if it is worth it...

  • Patch Set #25, Line 203: 'i'}

    I guess this would be a breaking change, I would defer to Nico and Angels judgement here. […]

    it was an oversight on my part... I will move back to image. As it stands we want the meaning to be the same...

To view, visit change 23021. To unsubscribe, or for help writing mail filters, visit settings.