29 Sep
2019
29 Sep
'19
4:30 p.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30410 )
Change subject: Fix -Wunused-parameter issues ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/flashrom/+/30410/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/30410/5//COMMIT_MSG@10 PS5, Line 10: __attribute__ ((unused)).
you could do `#define param_unused __attribute__((unused))` and use that prefix instead? Seems clean […]
We would then still be using __attribute__ ((unused)) anyway :P
--
To view, visit https://review.coreboot.org/c/flashrom/+/30410
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If831398c91e9f49bd5216a03ed4caaa2a7ab02bd
Gerrit-Change-Number: 30410
Gerrit-PatchSet: 5
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Richard Hughes richard@hughsie.com
Gerrit-Reviewer: Stefan T stefan.tauner@gmx.at
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 29 Sep 2019 14:30:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan quasisec@chromium.org
Gerrit-MessageType: comment