Attention is currently required from: Nico Huber, Angel Pons, Sergii Dmytruk.
5 comments:
Commit Message:
You've probably tested this patch, probably by running dummyflasher with some programmer params. It would be great to add this info into a commit message.
File dummyflasher.c:
Patch Set #10, Line 47: uint8_t emu_status_len; /* number of emulated status bytes */
Is this a number of emulated status bytes in SR2?
Patch Set #10, Line 342: /* XXX: Else reset SR2 parts to zero? */
What does it mean? Is it a TODO?
Patch Set #10, Line 930: data->emu_status_len = 1;
Maybe I missed something, but is this value always initialised to 1?
File flashrom.8.tmpl:
Patch Set #10, Line 781: is an 8-bit or 16-bit hexadecimal value.
What does this value mean? I know it was like this before ;) But since you are changing/upgrading this programmer param, you probably know what it is and can add some explanation here. Ideally also examples of 8-bit and 16-bit spi_status values.
To view, visit change 59072. To unsubscribe, or for help writing mail filters, visit settings.