Attention is currently required from: Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Simon Glass.

View Change

1 comment:

• File tests/init_shutdown.c:

  • Patch Set #10, Line 53: MEC1308_SIO_PORT1

    Just to add one comment, adding tests to code that has not been written with testing in mind is ofte […]

    It depends much on what one wants to test. Sharing the numbers with the
    tests implies _not_ testing if flashrom (still) uses the correct numbers.

    I don't know much about designing code for testing. Pulling such
    definitions out of their compilation unit makes it easier to write
    tests I suppose. But it also makes it harder to read/review the code.

To view, visit change 51487. To unsubscribe, or for help writing mail filters, visit settings.