Attention is currently required from: Anastasia Klimchuk, Miklós Márton, Stefan Reinauer, Thomas Heijligen.

View Change

1 comment:

• Patchset:

  • Patch Set #4:

    Thomas, do you plan any more testing? Which include path do you mean, is that the one hardcoded in m […]

    I attempted to test that the build worked as expected when the library path doesn't exist and found that the library handing was too clever and broke builds with `programmer=auto` when the library wasn't found:

    ```
    ../meson.build:546:26: ERROR: Unknown method "name" in object <[ExternalLibraryHolder] holds [ExternalLibrary]: <ExternalLibrary ni845x: False>> of type ExternalLibraryHolder.
    ```

    I fixed that by always setting `libni845x` to the real dependency on Windows (reintroducing the manual check for include directory existence which is required), and tested these cases:
     * Windows with `programmer=auto`: successful build without ni845x
     * Windows with programmer=auto and ni845x_search_path pointing to a directory that doesn't exist: successful build
     * Windows with ni845x and search path as default: successful build
     * Windows with `programmer=ni845x_spi` and `ni845x_search_path=C:\foobar\`: fails because library is not found
     * Linux with programmer=auto: successful build
     * Linux with programmer=ni845x_spi: error, programmer not supported on this platform

To view, visit change 75236. To unsubscribe, or for help writing mail filters, visit settings.