Attention is currently required from: Antonio Vázquez Blanco, David Reguera Garcia (Dreg), Matti Finder, Miklós Márton, Nikolai Artemiev, Sergii Dmytruk.
View Change
2 comments:
Patchset:
Commit Message:
Patch Set #2, Line 8:
My only comment here is that now that the patch goes across the whole tree, maybe you can add to a commit description,
to mention that after moving spi declarations some of the file don't need to include flash.h because spi.h is sufficient, and so includes of flash.h are removed where they are unnecessary.
To view, visit change 85539. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I794a71536a3b85fde39f83c802fa0f5dd8d428e0
Gerrit-Change-Number: 85539
Gerrit-PatchSet: 2
Gerrit-Owner: Antonio Vázquez Blanco <antoniovazquezblanco@gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: David Reguera Garcia (Dreg) <regueragarciadavid@gmail.com>
Gerrit-Reviewer: Matti Finder <matti.finder@gmail.com>
Gerrit-Reviewer: Miklós Márton <martonmiklosqdev@gmail.com>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: Peter Marheine <pmarheine@chromium.org>
Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Antonio Vázquez Blanco <antoniovazquezblanco@gmail.com>
Gerrit-Attention: Miklós Márton <martonmiklosqdev@gmail.com>
Gerrit-Attention: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Attention: David Reguera Garcia (Dreg) <regueragarciadavid@gmail.com>
Gerrit-Attention: Matti Finder <matti.finder@gmail.com>
Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Gerrit-Comment-Date: Thu, 12 Dec 2024 12:00:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No