Attention is currently required from: Nico Huber, Thomas Heijligen, Paul Menzel, Edward O'Callaghan, Aarya.

View Change

1 comment:

• File flashrom.c:

  • Patch Set #42, Line 1249: index

    maybe a better identifier than "index" and short hand for "i"ndex then?

    Maybe:
    `index` -> `layout_idx`
    `i` -> `eraser_idx`

    looks like this:
    layout[layout_idx]
    chip->block_erasers[eraser_idx]

    Would be better to understand at declaration level. However as an array_index it´s a bit doubling the words. Don´t know what to prefer.

    What do you think?

To view, visit change 65879. To unsubscribe, or for help writing mail filters, visit settings.