View Change
1 comment:
File ichspi.c:
Patch Set #1, Line 2011: "for 100+ series PCH.\n");
nit: mention Apollo Lake too?
Isn't this all done already by the strings in chipset_enable.c ? I think this is the wrong place to be printing this stuff apart from the fact that we are taking the PCH100+ path here.
snip from cros tree:
```
chipset_enable.c: {0x8086, 0x5af0, B_FS, OK, "Intel", "Apollolake", enable_flash_apl},
```
To view, visit change 43894. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I35535c3dac9fa796d204d60e5fc72a7d5f85d706
Gerrit-Change-Number: 43894
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Sun, 26 Jul 2020 11:02:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: comment