Attention is currently required from: Anastasia Klimchuk.

View Change

2 comments:

• File cli_getopt.c:

  • Patch Set #1, Line 28: #include "cli_getopt.h"

    I noticed you put this line on the top, why? Usually the style we have is: first come includes in <> […]

    Sorry, this is even subconscious for me. I do this because cli_getopt.h is the interface for cli_getopt.c, for this reason, including cli_getop.h first helps debug whether that header file is fully independent from any of the other includes in the "c" file.

    After that, I usually try to include other project headers and finally system headers because this strategy helps with producing clean includes...

    I've changed the use of quotes but left the include on the top. Please let me know if you prefer to change it. Thanks!

  • Patch Set #1, Line 35: // msg_gerr

    I noticed you are adding this comments for includes of flash. […]

    Acknowledged

To view, visit change 85072. To unsubscribe, or for help writing mail filters, visit settings.