Attention is currently required from: Nico Huber, Angel Pons.
View Change
1 comment:
Commit Message:
Patch Set #1, Line 17: not ignored anymore.
You do this for a lot of programmer drivers that are otherwise […]
You are right, I agree! I initially did "the same thing as before" but actually par masters are different, most of them don't have shutdown function. Totally makes sense to have a separate commit for those.
I left two programmers here, which do have shutdown function. All the rest is in next commit, and the commit message explains what's happening (fix propagation of return values).
To view, visit change 57156. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ief7be907f53878b4b6567b52889735e5fff64ead
Gerrit-Change-Number: 57156
Gerrit-PatchSet: 2
Gerrit-Owner: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Comment-Date: Fri, 27 Aug 2021 06:12:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Gerrit-MessageType: comment