Attention is currently required from: Sam McNally, Angel Pons, Peter Marheine.
View Change
1 comment:
Commit Message:
Patch Set #1, Line 7: CHROMIUM:
Is the CHROMIUM: prefix commonly used here?
Since it is a new thing for Chromium Flashrom and upstream Flashrom to be collaborating now there is no prior art to a convention specifically for Flashrom obviously. However, this is a convention for Coreboot which is the closest thing to draw upon and so sensible to use that here.
To view, visit change 49915. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If43aea0580fcc7e698daad2ffe085a3c9da5bc41
Gerrit-Change-Number: 49915
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Peter Marheine <pmarheine@chromium.org>
Gerrit-Reviewer: Sam McNally <sammc@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Sam McNally <sammc@google.com>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Peter Marheine <pmarheine@chromium.org>
Gerrit-Comment-Date: Wed, 27 Jan 2021 05:51:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sam McNally <sammc@google.com>
Gerrit-MessageType: comment