Attention is currently required from: Hsuan Ting Chen, Subrata Banik.
Patch set 2:Code-Review +2
1 comment:
Patchset:
> > Thank you for catching this! […]
Oh sorry, I only read this message now! You have two questions here.
#1
The rules for merging patches we have documented here: https://flashrom.org/dev_guide/development_guide.html#merging-patches
In this case, what applies is p.6, the normal process is 3days between full approval and merging.
24h, that could be some coreboot rules maybe? Not sure, but in any case, we have our process documented.
I can understand you might be worried the patch may be approved and then forgotten, but such things are no longer happening nowadays. I have setup such that I can easily check which patches are ready for merging, and other people probably have their own setups too.
For me, it's one of the best things, to merge someone's work into the tree. I like our contributors and value the contributions <3
#2
If you have been serious about submit right, this is great to know! It would be fantastic to have you, with your knowledge and experience, to be one of the maintainers and take on some duties to care of flashrom.
Our submit and approval rights are, in fact, duties, which is also documented, here: https://flashrom.org/about_flashrom/team.html
Tell me if you are interested! The first step would be for you to take some area of flashrom to maintain, and subscribe yourself into MAINTAINERS file.
Meanwhile, this patch is indeed ready, I will merge it now.
To view, visit change 83143. To unsubscribe, or for help writing mail filters, visit settings.