David Hendricks has posted comments on this change. ( https://review.coreboot.org/20570 )
Change subject: ichspi: Check if region is included before disabling writes ......................................................................
Patch Set 1: Code-Review-1
(1 comment)
Uploaded for convenience for now, needs a bit more work.
https://review.coreboot.org/#/c/20570/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/20570/1//COMMIT_MSG@9 PS1, Line 9: which are not restricted Verification needs to be taken into account: - If any region is read-locked, then --noverify-all must be used. (There was brief discussion of enabling --noverify-all by default for the ME region case, since that's a given).
- The region specified must not be read locked if --noverify-all is used, since "write-only" is a valid permission.