Attention is currently required from: Anastasia Klimchuk.

View Change

1 comment:

• File tests/erase_func_algo.c:

  • Patch Set #22, Line 270: 0xff

    Hi Anastasia:

    I'd like to ask if this test should avoid putting 0xff into either initial_buf or written_buf:

    If there are some addresses that are already 0xff, will there be multiple choice of erasure?

    For example,
    ```
    .initial_buf = {0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,
                    0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff},
    .written_buf = {0x0, 0x1, 0x2, 0x3, 0x4, 0x5, 0x6, 0x7, 0x8, 
                    0x9, 0xa, 0xb, 0xc, 0xd, 0xe, 0xf},
    ```

    It should be both valid that
    (1) Erase all, then write
    (2) Notice that the initial_buf are all 0xff, then skipped

    IIUC, both cases are valid and it is not able to decide which should be the "golden example".

    I am not really familiar about erasing algorithm, please let me know if I misunderstood anything.

    
    ---

    I tried to create one: https://review.coreboot.org/c/flashrom/+/79229

To view, visit change 67535. To unsubscribe, or for help writing mail filters, visit settings.