Attention is currently required from: Name of user not set #1005084.
10 comments:
Commit Message:
Patch Set #1, Line 7: MX2525643G
Let's use exact name MX25U25643G , can you please update?
Patch Set #1, Line 8: MX2525635F
Same here, probably MX25U25635F
Patch Set #1, Line 10: Tested: read, write and erase.
Could you please add info which programmer you ran?
Datasheet is available at the following URL:
https://www.mxic.com.tw/Lists/Datasheet/Attachments/8766/MX2525643G,%201.8V.%20256Mb,%20v1.1.pdf
You need to update the link (the new one you gave me in the comment works)
Patchset:
Dear Anastasia Klimchuk […]
Thank you, new link works, I opened datasheet successfully.
I added some comments, you will need to make changes to your patch and then upload new version and respond to comments.
If you have questions, feel free to ask!
File flashchips.c:
Patch Set #1, Line 10094: MACRONIX_MX25U25643G
After you fix my other comment about id, you will change this to MACRONIX_MX25U25635F
{
.eraseblocks = { {4 * 1024, 8192} },
.block_erase = SPI_BLOCK_ERASE_21,
},
Maybe I am missing something, I don't see this in the datasheet. I can see 20h for sector erase but not 21?
{
.eraseblocks = { {32 * 1024, 1024} },
.block_erase = SPI_BLOCK_ERASE_52,
},
same
.eraseblocks = { {64 * 1024, 512} },
.block_erase = SPI_BLOCK_ERASE_DC,
}, {
same
File include/flashchips.h:
Patch Set #1, Line 530: #define MACRONIX_MX25U25643G 0x2539
Don't add the same id, add a comment on existing id (MACRONIX_MX25U25635F), like that:
/* Same as MACRONIX_MX25U25635F */
You can look at examples of the same situation with same ids just few lines above in this file.
To view, visit change 76853. To unsubscribe, or for help writing mail filters, visit settings.