Sorry, I feel like I have to make a stand here. This whole
story (including earlier patches) is getting incredibly
ridiculous. There are nice warning options in todays
compilers, but if a warning option sucks and makes us
write worse code, then we shouldn't use it. I've wasted
so much time discussing such options, that I could have
spend reviewing and fixing actual bugs instead. IMHO,
some warning options just make things worse.

If we feel like we need to write /* zero initialized */
because we do that implicitly and rely on that, while the
language actually offers a nice and clean way to do that
explicitly, then we failed, desperately. If we want a nice
Clang experience, please let's just disable that ridiculous
warning.

Patch set 7:Code-Review -1

View Change

1 comment:

To view, visit change 36946. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3d01f4ff620f4c4111dd675d49ce3254f2360b29
Gerrit-Change-Number: 36946
Gerrit-PatchSet: 7
Gerrit-Owner: Ryan O'Leary <ryanoleary@google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Ryan O'Leary <ryanoleary@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich@gmail.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Mon, 16 Dec 2019 10:11:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Ryan O'Leary <ryanoleary@google.com>
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Gerrit-MessageType: comment