4 comments:
Patch Set #22, Line 52: .SH DESCRIPTION
Hmmm, new gerrit UI refused to save after editing above comment... […]
Thanks for clarifying, done. As you say it prints as follows now:
flashrom [-h|-R|-L|-z|-p <programmername>[:<parameters>]
[-E|-r <file>|-w <file>|-v <file>] [-c <chipname>]
[(-l <file>|--ifd| --fmap|--fmap-file <file>) [-i <image>]]
[-n] [-N] [-f]]
[-V[V[V]]] [-o <logfile>]
Now the malloc error path is missing the finalize_flash_access()...
d'oh... fixed.
Patch Set #24, Line 281: * should be a valid, usable fmap. */
Should we set `ret = 2` here too?
Yes, that makes sense.
*fmap_out = fmap;
ret = 0;
_free_ret:
if (ret)
free(fmap);
finalize_flash_access(flashctx);
Now that the code is more straight forward to read. We don't need […]
Yep, done.
To view, visit change 23203. To unsubscribe, or for help writing mail filters, visit settings.