Anastasia Klimchuk submitted this change.

View Change



2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Approvals: Anastasia Klimchuk: Looks good to me, approved build bot (Jenkins): Verified
ich_descriptors: Fix table printing

The code uses "%-4s" to print the master names and thus assumes that
all names have 4 characters or less. Convert "unknown" to "DevE",
short for Device Expansion in order to properly display the table.

Test: Run flashrom -p internal -VV

Change-Id: I0d10e2771c7a27c1a73ed53a33e68a04eb9e1e00
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/78301
Reviewed-by: Anastasia Klimchuk <aklm@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
M ich_descriptors.c
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ich_descriptors.c b/ich_descriptors.c
index 4b440ed..c3d062e 100644
--- a/ich_descriptors.c
+++ b/ich_descriptors.c
@@ -491,7 +491,7 @@
cs == CHIPSET_600_SERIES_ALDER_POINT ||
cs == CHIPSET_JASPER_LAKE || cs == CHIPSET_METEOR_LAKE) {
const char *const master_names[] = {
- "BIOS", "ME", "GbE", "unknown", "EC",
+ "BIOS", "ME", "GbE", "DevE", "EC",
};

if (nm > (ssize_t)ARRAY_SIZE(master_names)) {

To view, visit change 78301. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I0d10e2771c7a27c1a73ed53a33e68a04eb9e1e00
Gerrit-Change-Number: 78301
Gerrit-PatchSet: 4
Gerrit-Owner: Patrick Rudolph <rudolphpatrick05@gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged