Angel Pons submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Frans Hendriks: Looks good to me, but someone else must approve Edward O'Callaghan: Looks good to me, approved
chipset_enable.c: Mark Intel Q67 as DEP

Tested reading, writing and erasing the internal flash chip using an HP
Elite 8200 mainboard with an Intel Q67 PCH. However, since ME-enabled
chipsets are marked as DEP instead of OK, this one shall also be.

Change-Id: I2bd431c5c72824654b6b5b840f9af55dfe9d3554
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/47797
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Frans Hendriks <fhendriks@eltan.com>
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
---
M chipset_enable.c
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/chipset_enable.c b/chipset_enable.c
index 04ff9d8..5e4a547 100644
--- a/chipset_enable.c
+++ b/chipset_enable.c
@@ -1829,7 +1829,7 @@
{0x8086, 0x1c4b, B_FS, NT, "Intel", "HM67", enable_flash_pch6},
{0x8086, 0x1c4c, B_FS, NT, "Intel", "Q65", enable_flash_pch6},
{0x8086, 0x1c4d, B_FS, NT, "Intel", "QS67", enable_flash_pch6},
- {0x8086, 0x1c4e, B_FS, NT, "Intel", "Q67", enable_flash_pch6},
+ {0x8086, 0x1c4e, B_FS, DEP, "Intel", "Q67", enable_flash_pch6},
{0x8086, 0x1c4f, B_FS, DEP, "Intel", "QM67", enable_flash_pch6},
{0x8086, 0x1c50, B_FS, NT, "Intel", "B65", enable_flash_pch6},
{0x8086, 0x1c52, B_FS, NT, "Intel", "C202", enable_flash_pch6},

To view, visit change 47797. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2bd431c5c72824654b6b5b840f9af55dfe9d3554
Gerrit-Change-Number: 47797
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Frans Hendriks <fhendriks@eltan.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged