Attention is currently required from: David Hendricks, Kyösti Mälkki, Patrick Georgi, Patrick Rudolph, Patrick Rudolph.
View Change
1 comment:
Patchset:
Patch Set #5:
The previous patches are just for pretty printing a table that is visible at verbosity=3. […]
Yes I understand! But all 3 patches are modifying the same file (ich_descriptors.c) so the easier thing would be to merge the chain together. Besides, even if that's a pretty printing, but that's useful fixes and I definitely want to get all that through.
And there's not much to do for the other two: just commit message format, and one more question was for my education :) Thank you!
To view, visit change 78186. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I80eebc0fcc14de9df823aceaee77870ad136f94a
Gerrit-Change-Number: 78186
Gerrit-PatchSet: 5
Gerrit-Owner: Patrick Rudolph <rudolphpatrick05@gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Patrick Georgi <patrick@coreboot.org>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Attention: Patrick Georgi <patrick@coreboot.org>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-Attention: David Hendricks <david.hendricks@gmail.com>
Gerrit-Attention: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Attention: Patrick Rudolph <rudolphpatrick05@gmail.com>
Gerrit-Comment-Date: Tue, 24 Oct 2023 01:18:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph@9elements.com>
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-MessageType: comment