Attention is currently required from: Xiang Wang, Stefan Reinauer, Angel Pons.

View Change

2 comments:

• File bitbang_spi.c:

  • Patch Set #12, Line 208:

    
    	if (parse_spi_mode(&cpol, &cpha))
    		return ERROR_FLASHROM_BUG;
    

    If the parameter mode is not set, parse_spi_mode returns 0. […]

    Where are they initialised to 0?

    Also you may as well update the man page in this commit then for completeness.

• File bitbang_spi.c:

  • Patch Set #14, Line 41:

    
    static int cpol; /* Clock Polarity */
    static int cpha; /* Clock Phase */
    

    sounds like you want,

    ```
    static int cpol = 0; /* Clock Polarity */
    static int cpha = 0; /* Clock Phase */
    ```

To view, visit change 49255. To unsubscribe, or for help writing mail filters, visit settings.