Looks good overall, but I'd want to have a closer look after
the style issues are fixed (tabs should be 8 characters in
width).

View Change

4 comments:

• File programmer.h:

  • Patch Set #2, Line 125:

    Use tab for indent, please.

• File stlinkv3_spi.c:

  • Patch Set #2, Line 39: } fw_version_check_result_t;

    No typedefs, please. It would hide the fact that this is an `enum`
    all over the code.

    (And someone once told me that `_t` is reserved for standard C types.

  • Patch Set #2, Line 50: SPI

    Just personal taste: I understand that SPI is an acronym and hence the
    urge to write it in all caps, but it doesn't seem to make it easier to
    read (nor to type).

  • Patch Set #2, Line 131: actualLength

    `actual_length` (no CammelCase, please)

To view, visit change 34661. To unsubscribe, or for help writing mail filters, visit settings.