Attention is currently required from: Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Peter Marheine.

Edward O'Callaghan uploaded patch set #4 to this change.

View Change

programmer.h: Make pacc global state static local

chipset_enable.c has some fragile pci logic to deal
with Intel's complexity of finding the SPI controller
on the ICH.

Here we provide function to allow pushing the scope of
pci access global state inwards into a static local of
just pcidev. While by no means perfection, this does
at least make it easier to reason about 'pacc' control
flow now.

BUG=none
TEST=builds

Change-Id: I3bea1b93a7ca81dd42a64eec1e49a10f1fbda850
Signed-off-by: Edward O'Callaghan <quasisec@google.com>
---
M chipset_enable.c
M pcidev.c
M programmer.h
3 files changed, 18 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/78/59278/4

To view, visit change 59278. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3bea1b93a7ca81dd42a64eec1e49a10f1fbda850
Gerrit-Change-Number: 59278
Gerrit-PatchSet: 4
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Peter Marheine <pmarheine@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Attention: Peter Marheine <pmarheine@chromium.org>
Gerrit-MessageType: newpatchset