Just some smaller remarks.

View Change

4 comments:

• File flashrom.8.tmpl:

  • Patch Set #1, Line 725: channel/interface/port

    I think "channel/interface/port" refer all to the same parameter
    `port`. So the whole sentence should probably be something like:

      Optional parameters specify the controller, channel/interface/
      port and GPIO-based chip select to use.

• File ft2232_spi.c:

  • Patch Set #1, Line 331: && strlen(arg)

    I know it's a common pattern, but doesn't it prevent an error message
    to be printed when somebody specifies `-p ft2232_spi:csgpiol=` without
    a number?

    Your call.

  • Patch Set #1, Line 332: = 0

    Unnecessary initialization.

  • Patch Set #1, Line 342: cs_bits |= 1 << pin;

    This keeps the original bit (0x08) to assert CS. Probably a rather
    rare use-case, but what if somebody would want to use the new parameter
    to choose between different chips?

To view, visit change 28911. To unsubscribe, or for help writing mail filters, visit settings.