Attention is currently required from: Felix Singer, Nico Huber, Thomas Heijligen, Angel Pons, Alexander Goncharov.

View Change

2 comments:

• File dirtyjtag_spi.c:

  • Patch Set #11, Line 74: const

    Let's drop the `const` from the parameter, so that the `const` doesn't need to be cast away.

    I don't quite like it (dirtyjtag_send could use a const pointer), but after re-reading libusb's documentation I have found no guarantee that there won't any writes for a read transaction.

    So let's drop the const.

  • Patch Set #11, Line 167: const

    This `const` would also need to be dropped.

    Done

To view, visit change 67878. To unsubscribe, or for help writing mail filters, visit settings.