Attention is currently required from: Simon Buhrow, Edward O'Callaghan. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/43282 ) Change subject: ft2232_spi.c: change the chunksize to 280 ...................................................................... Patch Set 4: Code-Review+1 (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/43282/comment/cfa1a450_5be3f683 PS4, Line 9: This is necessary for change CB:40477 (time saving patch). Does CB:40477 require this change? If so, please reorder the commits. You can reorder the last two commits using `git rebase`: https://stackoverflow.com/a/49452944 File ft2232_spi.c: https://review.coreboot.org/c/flashrom/+/43282/comment/5c38a5fe_ba13c8cc PS4, Line 401: 280)
should this be a define up at the top of the file with the comment above as the rational for the val […] Good idea. The define could even be spelled out:
#define FTDI_CHUNK_SIZE (9 + 1 + 9 + 1 + 4 + 256) -- To view, visit https://review.coreboot.org/c/flashrom/+/43282 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5e096937834fc8fc8623c8c59ade529de081b72a Gerrit-Change-Number: 43282 Gerrit-PatchSet: 4 Gerrit-Owner: Simon Buhrow Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Edward O'Callaghan <quasisec@chromium.org> Gerrit-CC: Nico Huber <nico.h@gmx.de> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Simon Buhrow Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Comment-Date: Tue, 20 Apr 2021 08:28:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Edward O'Callaghan <quasisec@chromium.org> Gerrit-MessageType: comment