Attention is currently required from: Simon Buhrow, Edward O'Callaghan. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/43282 )
Change subject: ft2232_spi.c: change the chunksize to 280 ......................................................................
Patch Set 4: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/43282/comment/cfa1a450_5be3f683 PS4, Line 9: This is necessary for change CB:40477 (time saving patch). Does CB:40477 require this change? If so, please reorder the commits. You can reorder the last two commits using `git rebase`: https://stackoverflow.com/a/49452944
File ft2232_spi.c:
https://review.coreboot.org/c/flashrom/+/43282/comment/5c38a5fe_ba13c8cc PS4, Line 401: 280)
should this be a define up at the top of the file with the comment above as the rational for the val […]
Good idea. The define could even be spelled out:
#define FTDI_CHUNK_SIZE (9 + 1 + 9 + 1 + 4 + 256)