Attention is currently required from: Felix Singer, Edward O'Callaghan, Angel Pons, Alexander Goncharov.
4 comments:
File flashrom.c:
You can leave "return" in this case, I think return sounds good here.
Patch Set #4, Line 924: char *ret, *ptr;
I am going to ask silly question: why do you need both?
If there is a reason, I think it can be a comment.
Patch Set #4, Line 935: Once all chipsets and flash chips have been updated
An open question to everyone who reads this: what does it even mean? :)
Specifically, I am wondering what should happen so that this fixme can be fixed.
if (bustype == BUS_NONSPI)
return strdup("Non-SPI");
if (bustype == BUS_NONE)
return strdup(bustypes[bustype]);
These first two cases (BUS_NONSPI and BUS_NONE) are specially handled in the code, I understand why, but what looks a bit odd is that the former is hard-coded, the latter is taken from an array. Why the difference? Do you need BUS_NONE is the array? Maybe make it hard-coded too, and remove from array?
To view, visit change 73039. To unsubscribe, or for help writing mail filters, visit settings.