Anastasia Klimchuk submitted this change.

View Change


Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Alexander Goncharov: Looks good to me, but someone else must approve
nicintel_eeprom.c: Fix typo

`done_i20_write` is meant to be `done_i210_write`. Fix that.

Signed-off-by: Felix Singer <felixsinger@posteo.net>
Change-Id: Idc0a0c475e891fc8538a7a81093520e01e1b25bf
Reviewed-on: https://review.coreboot.org/c/flashrom/+/68582
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Alexander Goncharov <chat@joursoir.net>
---
M nicintel_eeprom.c
1 file changed, 20 insertions(+), 4 deletions(-)

diff --git a/nicintel_eeprom.c b/nicintel_eeprom.c
index d93f8e0..ff2c3ce 100644
--- a/nicintel_eeprom.c
+++ b/nicintel_eeprom.c
@@ -81,7 +81,7 @@
uint32_t eec;

/* Intel I210 variable(s) */
- bool done_i20_write;
+ bool done_i210_write;
};

/*
@@ -225,7 +225,7 @@
unsigned int addr, unsigned int len)
{
struct nicintel_eeprom_data *opaque_data = flash->mst->opaque.data;
- opaque_data->done_i20_write = true;
+ opaque_data->done_i210_write = true;

if (addr & 1) {
uint16_t data;
@@ -414,7 +414,7 @@
struct nicintel_eeprom_data *data = opaque_data;
int ret = 0;

- if (!data->done_i20_write)
+ if (!data->done_i210_write)
goto out;

uint32_t flup = pci_mmio_readl(data->nicintel_eebar + EEC);
@@ -528,7 +528,7 @@
data->nicintel_pci = dev;
data->nicintel_eebar = eebar;
data->eec = eec;
- data->done_i20_write = false;
+ data->done_i210_write = false;

return register_opaque_master(mst, data);
}

To view, visit change 68582. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Idc0a0c475e891fc8538a7a81093520e01e1b25bf
Gerrit-Change-Number: 68582
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Alexander Goncharov <chat@joursoir.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged