Attention is currently required from: Edward O'Callaghan, Neill Corlett.
18 comments:
Commit Message:
nit: no period at the end of commit summaries
File mediatek_i2c_spi.c:
#define ISP_PORT 0x92 >> 1
#define DEBUG_PORT 0xb2 >> 1
Please wrap these in parentheses to avoid operation order problems:
#define ISP_PORT (0x92 >> 1)
#define DEBUG_PORT (0xb2 >> 1)
nit: double blank line
Patch Set #1, Line 55: uint8_t* buf
The `*` unary operator should have a space before, not after:
uint8_t *buf
Same applies to the rest of the file.
We know `len` is non-zero, special case is handled above. But I'd still keep this check here for clarity.
ARRAY_SIZE(data)
Macro is defined in flash.h
Patch Set #1, Line 187: size_t len = 1;
Variable seems to be unnecessary
ARRAY_SIZE(data)
Patch Set #1, Line 242: GPIO line
Is this board depended? Should this perhaps become a programmer parameter if so? i.e. […]
+1
Patch Set #1, Line 249: 0x426, 7
What are these magic numbers?
Patch Set #1, Line 255: 0x428, 7
What are these magic numbers?
Please move the brace to the following line
Patch Set #1, Line 269: unsigned char
This assumes that the size of `unsigned char` is always 1 byte. I'd use `uint8_t`.
Patch Set #1, Line 271: sizeof
Along with the changes above, this should then be `ARRAY_SIZE`
Please use lowercase for hex
Please move the brace to the following line
If both attempts fail, can we assume that entering ISP has failed?
Please move the brace to the following line
To view, visit change 61288. To unsubscribe, or for help writing mail filters, visit settings.