Attention is currently required from: Edward O'Callaghan, Felix Singer, Angel Pons, Michael Niewöhner, Anastasia Klimchuk.

View Change

2 comments:

• Commit Message:

  • Patch Set #1, Line 28:

    ***RFC*** We could maintain a list of revisions/lengths but is it really
    worth it?
    
    

    Good question. I think there are three cases: […]

    Sounds much like we'd want to check that the length is at least that of 1.0 (or
    more specifically the minimum length that covers the last parameter that flashrom
    consumes) and that the major version is 1.

• File sfdp.c:

  • Patch Set #2, Line 133:

    	msg_cdbg("Parsing JEDEC flash parameter table... ");
    	msg_cdbg2("\n");
    

    Looks like these two message can be merged into one now. […]

    The line break is only wanted if the next message is at level dbg2 too.

To view, visit change 60055. To unsubscribe, or for help writing mail filters, visit settings.