Attention is currently required from: Hung-Te Lin, Nico Huber, Edward O'Callaghan, Angel Pons, Patrick Rudolph.

View Change

1 comment:

• Patchset:

  • Patch Set #2:

    The comment said "Try to align reads to eraseblock size.".

    So, if you use fread, the stdio may do unaligned reads internally. If we call read directly, at least we can look at return values, decide if we should go back to previous aligned offset and read again.

    You only included half the comment, though! The full comment also has:
    ```
    		 * FIXME: Shouldn't actually be necessary, but not all MTD
    		 * drivers handle arbitrary large reads well.
    ```

    Not only does that imply that the alignment shouldn't really be necessary but also that the problem being worked around was reads that were too large. I guess it was the chunking that was important not the alignment but the two were conflated in the comment.

To view, visit change 50206. To unsubscribe, or for help writing mail filters, visit settings.