Patch set 2:Code-Review +1
View Change
2 comments:
Commit Message:
Patch Set #2, Line 9: This aligns the upstream master branch with chromium's.
Nit, don't break lines after every sentence...
Patch Set #2, Line 10: On-the-fly opcode reprogramming is supported by both branches so the default opcode shouldn't matter
...but break them after 72 chars max.
And always end sentences with a full stop, please.
To view, visit change 34689. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I379549e8fa966e75e3d8b7932700df62cf50df64
Gerrit-Change-Number: 34689
Gerrit-PatchSet: 2
Gerrit-Owner: Mayur Panchal <panchalm@google.com>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Mayur Panchal <panchalm@google.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Fri, 09 Aug 2019 07:17:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment