Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer.
View Change
3 comments:
File flashchips.c:
Patch Set #1, Line 11104: 512B
Datasheet says `8K-bit secured OTP` so I think this is 1024B
Done
Patch Set #1, Line 11111:
{
.eraseblocks = { {4 * 1024, 8192} },
.block_erase = SPI_BLOCK_ERASE_21,
},
I don't see it in datasheet (I mean: 21h, 5Ch, DCh)? I see there is: […]
Please refer to the figure-55 to figure-57 which describe 21h, 5Ch, DCh command, thanks.
Patch Set #1, Line 11137: /* TODO: security register */
You can remove TODO, you added security register bits below
Done
To view, visit change 82777. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I8641f36e1909274629690fc243be46281a21360d
Gerrit-Change-Number: 82777
Gerrit-PatchSet: 1
Gerrit-Owner: DZ <danielzhang@mxic.com.cn>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Attention: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Comment-Date: Mon, 08 Jul 2024 02:24:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>