Attention is currently required from: Sergii Dmytruk.
View Change
1 comment:
File flashrom.c:
Patch Set #7, Line 1265: // TODO: take FEATURE_NO_ERASE into account?
I like the second approach better too. […]
Inspired by your suggestion, I made a solution which maybe not perfect, but at least it's simple (lines 1285-1290) :)
Total gets doubled for writing for no_erase chips, and then the rest running as normal.
To view, visit change 84439. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I88ac4d40f1b6ccc1636b1efb690d8d68bdebec08
Gerrit-Change-Number: 84439
Gerrit-PatchSet: 15
Gerrit-Owner: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Gerrit-Comment-Date: Sat, 26 Oct 2024 08:51:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>
Comment-In-Reply-To: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>