Attention is currently required from: Felix Singer, Edward O'Callaghan.

View Change

2 comments:

• File flashrom.c:

  • Patch Set #4, Line 219: flash->mst->buses_supported & BUS_SPI

    In case of multiple buses, this is not necessarily the bus that the flash […]

    Nevermind, I was thinking about a different variable. This
    one used to be the tag of a tagged union. So we could write
    `==` for clarity. (of course returning to a union would help
    readers a lot; the name also shouldn't be plural if it only
    supports a single bus)

  • Patch Set #4, Line 224: flash->mst->par.delay(usecs);

    This could probably be better solved by having a common master struct, […]

    Actually, if there will be common information to store, we could
    place it inside `registered_master`.

To view, visit change 67393. To unsubscribe, or for help writing mail filters, visit settings.