Attention is currently required from: Alexander Goncharov, Brian Norris, Edward O'Callaghan.

View Change

3 comments:

• File flashrom.c:

  • Patch Set #3, Line 2056: const bool read_it

    not used, drop it

    Done

  • Patch Set #3, Line 2057: const bool verify_it

    not used, drop it

    Done

  • Patch Set #3, Line 2060: int ret = 0;

    if ret were initialized as `-1` there would be no need for `ret = -1` in if branches.

    Setting the return code in each error branch is more idiomatic for C code IMO.

    Ideally each error block would just be `return <error code>;` but since we do a `goto ...` instead, keeping the assignment to ret at least indicates that we want to return a particular value at that point.

To view, visit change 75991. To unsubscribe, or for help writing mail filters, visit settings.