Attention is currently required from: Anastasia Klimchuk.
6 comments:
Patchset:
Thanks for being so nice Anastasia!
One more thing I forgot: in the email from Gerrit your name is "Name of user not set". […]
I'm not sure why this is happening. I followed step 6, in my 'https://review.coreboot.org/settings/' page I have full name, display name, and email set. I might have done things out of order for this commit though as I was still figuring out how to use gerrit, so I'll try updating the commit, and hopefully the email will work this time.
Commit Message:
Patch Set #1, Line 10: the project wouldnt compile with meson for me (MacOS 15.1)
I first thought that flashrom does not compile, but then I read your blog post and now I think maybe […]
I will try again with these updates.
Updated the serprog overview page with info about the Glasgow Interface Explorer as a valid programmer.
Wasnt able to test as the project wouldnt compile with meson for me (MacOS 15.1)
but tried to make it as similar as possible to what was already there.
We wrap commit message by 72 chars, and I think the first line is longer (maybe the second one too) […]
Apologies, will fix, thankyou!
File doc/supported_hw/supported_prog/serprog/overview.rst:
Patch Set #1, Line 105: Source for the Glasgow Project can be found `here <https://github.com/GlasgowEmbedded/glasgow>`_
This gives a warning `WARNING: Duplicate explicit target name: "here".` […]
This is my first time using rst and gerrit, sorry for all the newbie mistakes!
Did the second link generate a warning too or just the first? If only the first, I think it's saying 'here' is already used as a link target, so if I change that text to something unique it should work. I'll try that in the new commit.
And I'll try again to get my build to compile.
Patch Set #1, Line 108: 76hPuPkpDOTAxj7TegVqV8UkmKEjZ8TvLLBoDoVPpw
What is this hash? :) I assume that's by mistake?
Yep that definitely shouldn't be there. Thanks.
To view, visit change 85527. To unsubscribe, or for help writing mail filters, visit settings.