Attention is currently required from: Matti Finder, Nikolai Artemiev, Sergii Dmytruk, Stefan Reinauer.
View Change
2 comments:
Patchset:
Patch Set #2:
I wonder if `chip->tested. […]
1) Ignored in the meaning, not showing the message "flash has status untested for WP"?
2) Or ignored in the meaning, if it's set to OK, don't believe it because it can't be?
I think the first one, the message still useful: people see it and sometimes wonder and sometimes add support for WP. Apart from the very edge cases, like "generic" chip entries, I would keep the message (for now... but things can change).
The second option: I don't think there are such entries in flashchips at the moment. It has always been that the contributor who adds support also marks as tested.
Commit Message:
Patch Set #2, Line 12: SDFP chip and what would you report?
`SFDP`
Thank you! And I found the same typo in the commit message of the next patch too!
To view, visit change 85075. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I7e945389895a8042df3aaae72bccf73405be8651
Gerrit-Change-Number: 85075
Gerrit-PatchSet: 3
Gerrit-Owner: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Matti Finder <matti.finder@gmail.com>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Attention: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Gerrit-Attention: Matti Finder <matti.finder@gmail.com>
Gerrit-Comment-Date: Sun, 10 Nov 2024 23:44:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>
Comment-In-Reply-To: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>