Attention is currently required from: Kyösti Mälkki, Patrick Georgi, Patrick Rudolph, Patrick Rudolph.

View Change

3 comments:

• Patchset:

  • Patch Set #4:

    I was trying to find something public of "Intel SPI Programming Guide #619386" but I couldn't, is there anything public?
    Otherwise I will trust Patrick and David, they saw it with their own eyes :)

• File ich_descriptors.c:

  • Patch Set #4, Line 1024:

    if (content->ISL <= 80)
    			return CHIPSET_C620_SERIES_LEWISBURG
    

    It's not removed. This code path is never taken on C620 as ICCRIBA==0x34. […]

    I see now, thank you! Indeed it is just below.

  • Patch Set #4, Line 490: to be compatible with 500 Series PCH below

    I really like your explanation, I understand now after reading it! Do you think you can put it into the code comment (instead of current one)? This one:

    It says there are 6 masters (thus NM=6), but can only name 5. If there's a 6th then it's undocumented. However the first 5 are matching '500 Series PCH' and since C740 is a 500 Series clone, this field probably was not updated when writing the document.

To view, visit change 78186. To unsubscribe, or for help writing mail filters, visit settings.